Remove unneeded allocations parsing assets file

[davkean]

Bug

Fixes: NuGet/Home#11648

Regression? Last working version:

Description

Remove unneeded allocations parsing assets file

PR Checklist

• PR has a meaningful title

• PR has a linked issue.

• Described changes

• Tests

  • Automated tests added
  • OR
  • Test exception - No functional changes.
  • OR
  • N/A

• Documentation

  • Documentation PR or issue filled
  • OR
  • N/A

[nkolev92]

If you name your branch dev-*, something like dev-davkean-removeUnneededAllocations it will auto trigger the build.

[kartheekp-ms]

I found another code path where a similar fix can be applied. The fix is to replace the line no:712 with return new List<IAssetsLogMessage>(0); and replace line no: 715 with var items = new List<IAssetsLogMessage>(json.Count);

NuGet.Client/src/NuGet.Core/NuGet.ProjectModel/LockFile/LockFileFormat.cs

Lines 708 to 725 in b76bf48

	internal static IList<IAssetsLogMessage> ReadLogMessageArray(JArray json, string projectPath)
	{
	if (json == null)
	{
	return new List<IAssetsLogMessage>();
	}
	var items = new List<IAssetsLogMessage>();
	foreach (var child in json)
	{
	var logMessage = ReadLogMessage(child as JObject, projectPath);
	if (logMessage != null)
	{
	items.Add(logMessage);
	}
	}
	return items;
	}

[jeffkl]

I restarted the failing test job

[davkean]

@kartheekp-ms I fixed that one too.