Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations (looking for contributors) #345

Open
nukeop opened this issue Jun 5, 2019 · 88 comments · Fixed by #355
Open

Translations (looking for contributors) #345

nukeop opened this issue Jun 5, 2019 · 88 comments · Fixed by #355
Labels
enhancement This thread requests an enhancement to be implemented. good first issue This issue is a low hanging fruit perfect for new contributors and shouldn't take too much time. non-technical This issue does not require programming skills to complete.

Comments

@nukeop
Copy link
Owner

nukeop commented Jun 5, 2019

We're looking for contributors who are willing to translate Nuclear to their native languages (or any languages that they know well). Currently @charjac has done all the work required to add new translations, and also translated all the strings to French.

Suggest translations here: https://crowdin.com/project/nuclear

Guidelines can be found here: https://nukeop.gitbook.io/nuclear/contributing/translating

@nukeop nukeop added enhancement This thread requests an enhancement to be implemented. help wanted good first issue This issue is a low hanging fruit perfect for new contributors and shouldn't take too much time. labels Jun 5, 2019
@nukeop nukeop pinned this issue Jun 5, 2019
@c-jacquin
Copy link
Collaborator

c-jacquin commented Jun 6, 2019

When adding translations, a few things need to be done:

  • add the json file with the correct name in app/locales and keep it empty
  • update the i18n script in package.json by adding your locale
{
  ...
  "scripts": {
    ...
     "i18n": "sync-i18n --files 'app/locales/*.json' --primary en --languages fr [your locale] --space 2"
  } 
  ...
}
  • run the command
npm run i18n
  • edit the file common/settings.js to add your local in user's choice
  {
    name: 'language',
    category: 'program-settings',
    type: settingType.LIST,
    prettyName: 'language',
    placeholder: 'language-placeholder',
    options: ['en', 'fr', <your locale>],
    default: undefined
  }
  • edit the app/i18n.js file
...
import en from './locales/en.json';
import <your locale> from './locales/<your locale>.json';
...
    resources: {
      en,
      ...
      <your locale>
    },
...

you can now translate your locale file from english to your language.

After you're done, you can add your translation to the readme, under "Community translations".

@Hansen1992
Copy link
Contributor

Hey @nukeop, I would like to help you translate Nuclear from English to Danish if this has any interest?

@nukeop
Copy link
Owner Author

nukeop commented Jun 10, 2019

Absolutely, in general if you don't see a language on the list above, we want it added. Thanks for the help.

@lizzyd710
Copy link
Contributor

What kind of things or phrases would you like to be translated? I'm a native English speaker but I took a few years of Chinese (Mandarin, so I write simplified). I may not be able to do much, but I would be happy to start and do as much as I can.

@nukeop
Copy link
Owner Author

nukeop commented Jun 11, 2019

You can see a list of all strings that have to be translated here: https://github.com/nukeop/nuclear/blob/master/app/locales/en.json

Even if you only translate a part of it, any missing strings fall back on default English. And some is better than nothing.

@lizzyd710
Copy link
Contributor

lizzyd710 commented Jun 12, 2019

(This might not be the appropriate place for this, so I apologize and let me know if/where you want me to move this.) Do I need to run npm run i18n before editing app/constants/settings.js and app/i18n.js? I'm having some issues with setting up the NPM dev environment for working on this repo, and I'm wondering if I could just edit the files in the meantime to try and get started on the translations while I troubleshoot.

@c-jacquin
Copy link
Collaborator

c-jacquin commented Jun 12, 2019

npm run i18n just fill the new json file with english translation.
you can copy paste en.json content to (your locale).json, it will do the same.

wich error do you get when you setup dev environment ?

@lizzyd710
Copy link
Contributor

(If I should have posted this in pastebin or something else, let me know. I know different repos have different protocols for this type of thing.)
image

@c-jacquin
Copy link
Collaborator

arf windows :'( :'(

There is a few things you can try:

  • run your cmd as administrator
  • delete node_modules and then run npm install
  • maybe try gitbash ?
  • help !!! :)

@nukeop
Copy link
Owner Author

nukeop commented Jun 13, 2019

I think it's a matter of running npm install first.

@lizzyd710
Copy link
Contributor

Yeah, I reinstalled and it loaded, it's just stuck on the nuclear logo screen. Would I be able to run the i18n command though, or do I need to figure out why the app isn't loading first? (Again, sorry for clogging up this issue. Is there a better place for me to go for this, or is here fine?)

@lizzyd710
Copy link
Contributor

So, I was afraid this would be an issue with translating to Chinese, but even when I save the zh.json file with Unicode encoding it doesn't properly parse...how should I go about trying to handle this?

@nukeop
Copy link
Owner Author

nukeop commented Jun 13, 2019

Talking about it here is fine. Could you start a pull request with the changes you've made so far so I can pull them and check? Maybe it'll work fine for me, and even if it doesn't I'll be in a better position to judge what's wrong.

@ramstore07
Copy link
Contributor

Hey there! I would like to translate it to Russian! Let me know what you think!

@nukeop
Copy link
Owner Author

nukeop commented Jun 14, 2019

Sure, this is a great idea. Let me know if there are any problems.

@lizzyd710
Copy link
Contributor

Talking about it here is fine. Could you start a pull request with the changes you've made so far so I can pull them and check? Maybe it'll work fine for me, and even if it doesn't I'll be in a better position to judge what's wrong.

I think I figured it out. I saved it with Unicode encoding but I should have saved it as UTF-8. sigh

Now I just have to figure out how to actually get the program to get past the logo and I can test and submit a pull request.

@nukeop
Copy link
Owner Author

nukeop commented Jun 21, 2019

This is coming along really, really well. We've got 9 languages already, and it's barely been two weeks.

@nukeop
Copy link
Owner Author

nukeop commented Aug 3, 2021

Spanish is at 100% right now, so no need to do anything: https://crowdin.com/project/nuclear

@amendezm
Copy link
Contributor

amendezm commented Aug 3, 2021

@nukeop I mean the readme file of the repo

image
image

I don't see spanish there

@nukeop
Copy link
Owner Author

nukeop commented Aug 3, 2021

In this case, just create a file named README-[locale code].md, and add a link to it in the English readme.

@amendezm
Copy link
Contributor

amendezm commented Aug 4, 2021

@nukeop I just open a PR for this

@nattts
Copy link

nattts commented Oct 25, 2021

hi @nukeop, i would like to add translation to Latvian language. can i give it a go?

@nukeop
Copy link
Owner Author

nukeop commented Oct 25, 2021

@nattts - sure, thanks for the help. I added it on crowdin: https://crowdin.com/project/nuclear/lv

@SecularSteve
Copy link

I just translated Croatian, Dutch and German on CrowdIn. With a few additional checks, especially in Croatian.

Is it also possible to add Serbian and Bosnian?

@nukeop
Copy link
Owner Author

nukeop commented Nov 22, 2021

Awesome, I'll add them. How do you know so many languages?

@SecularSteve
Copy link

Bosnian, Croatian and Serbian are all much of the same, but with slight dialect differences. The only reason they're proclaimed different today is because of complicated socio-political reasons.

I already had experience with English and German, so learning Dutch was automatically a breeze.

@altela
Copy link
Contributor

altela commented Dec 23, 2021

Hi @nukeop
Just translated and finished Indonesian language.
Let me know if there's anything to help! i'd be glad to do so :D

@FahimFBA
Copy link

I was hoping for adding a translation in my native language, Bengali.

@nukeop
Copy link
Owner Author

nukeop commented Jan 30, 2022

Ok, I added Bengali on Crowdin, you should be able to start translating.

@rm-NoobInCoding
Copy link

Hi
Please add Persian language to Crowdin.
Thanks

@nukeop
Copy link
Owner Author

nukeop commented Aug 2, 2022

Thanks for the suggestion, I added it.

@Aftzalanc
Copy link

Hi @nukeop! Could I help with the Greek translation? It's my first time contributing to an open source project, so I might have a few questions, but I really want to help in any way I can 🙂 .

@nukeop
Copy link
Owner Author

nukeop commented Sep 2, 2022

Hi, sure, although Greek is already 91% complete.

@MagicLike
Copy link

Does German need any proofreading or is it completely translated?

@UnixCro
Copy link

UnixCro commented Sep 3, 2022

As a native German speaker, I corrected a few things back then. Many third-party translations were utter nonsense. If I were you, I would look and see what else you can find, since the owner cannot test German and therefore cannot give you the answer you expect...

@Aftzalanc
Copy link

Thank you @nukeop, I'll start and hopefully now it will reach 100%. I could also proofread the existing translations or try to translate the README.md (since I didn't see a Greek version) if that would be helpful.

@nukeop
Copy link
Owner Author

nukeop commented Sep 3, 2022

It always helps when native speakers confirm translations. There's around 25 languages or even more, and I have no choice but to accept whatever is contributed since its hard to estimate correctness.

@Aftzalanc
Copy link

Hello! So, just to make sure I have fully understood how crowdin works, if I have a translation for a string or I think one of the suggestions is correct, I just use and save it, right? Also, while proofreading, should I 'approve' every accurate translation?

@nukeop
Copy link
Owner Author

nukeop commented Sep 6, 2022

The first part is correct, if you want to proofread, feel free to approve as many strings you want, the more are approved by native speakers, the more confident we can be in the translation.

@Aftzalanc
Copy link

Hi. I seem to have stumbled across a somewhat minor dilemma. There are some words/phrases that could be translated in Greek, but in everyday life their translations are not used (they sound kind of formal/odd) and the original English words are preferred instead. For example, Plugins, Playback etc. I can use the translations if you believe it to be best though.
I appreciate your patience with all these questions and your guidance 🙂

@nukeop
Copy link
Owner Author

nukeop commented Sep 13, 2022

I think in this case it's better to use the original English, pretty sure that's what's used in other languages as well.

@nukeop nukeop unpinned this issue Nov 10, 2022
@NohaFahmi
Copy link
Contributor

@nukeop Hi, can I create a Readme in Arabic language and add it to the English Readme?

@nukeop
Copy link
Owner Author

nukeop commented Oct 6, 2023

Sure you can!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This thread requests an enhancement to be implemented. good first issue This issue is a low hanging fruit perfect for new contributors and shouldn't take too much time. non-technical This issue does not require programming skills to complete.
Projects
None yet
Development

Successfully merging a pull request may close this issue.