Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial on every page doesn't work #14

Closed
OussamaRomdhane opened this issue Sep 1, 2016 · 3 comments
Closed

Partial on every page doesn't work #14

OussamaRomdhane opened this issue Sep 1, 2016 · 3 comments

Comments

@OussamaRomdhane
Copy link

Hello,
Thank you for the beautiful module.
I have one complain though, partials seem to work fine when used in render but doesn't work for "every page"

app.set('partials', {footer: 'footer'});

@bengsfort
Copy link

This is the same issue as #2. There is support for this in the current version hosted here on github but the author hasn't published the new version to npm. I was only able to get it to work by adding this repo as a submodule in my node_modules folder. I'm sure there's a more elegant submodule solution but this is what worked for me last night at 1am:

git submodule add -f git@github.com:nullfirm/hjs.git ./node_modules/hjs

Since this doesn't seem to be getting updated its probably time to switch to another view engine.

@linslin
Copy link
Collaborator

linslin commented Mar 8, 2017

Due to no support on this library for months and a last release years a ago we decided to fork this lib to https://github.com/linslin/hjs and released a new version on NPM with all the latest fixes. The "bus factor" on this lib is to high. With our fork we try to get this lib back into life.

@OussamaRomdhane
Copy link
Author

Thank you guys for the responses, I'm not sure we can change to that new module soon (not a priority) but thanks a lot and I would probably use it in upcoming projects.
Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants