Rename .gitea to .gitmodules #279
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.gitmodulesis a default filename which shouldn't be changed and causes a downstream packaging issue in NixOS because we hardcoded it in our fetcher https://github.com/NixOS/nixpkgs/blob/master/pkgs/build-support/fetchgit/nix-prefetch-git#L210. We don't have any mechanism to rename the file between fetching and downloading submodules because so far there was no need for it. We also can't fetch the submodules later cause all our builds are sandboxed we do not have network access after the initial source download.As a side effect GitHub should now also display the submodules correct.
If you prefer to keep the file name like it is right now we can also work around that but I would prefer to keep the fetchers as simple as possible because bugs in them affect almost all parts of the package repository.