Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default port to ???? #133

Closed
Mortaro opened this issue Dec 25, 2021 · 4 comments · Fixed by #138
Closed

Change default port to ???? #133

Mortaro opened this issue Dec 25, 2021 · 4 comments · Fixed by #138
Assignees

Comments

@Mortaro
Copy link
Member

Mortaro commented Dec 25, 2021

Nullstack is crashing in some macbooks because port 5000 is taken, should we move to port 3000 like normies or do something else?

ಥ_ಥ i liked 5000

@Mortaro
Copy link
Member Author

Mortaro commented Dec 26, 2021

Nullstack should not have a default port on its sourcecode, it should read from NULLSTACK_SERVER_PORT or PORT, if its not in server.less mode and does not have a defined port it should stop execution with an error in the console (should be red)
The port should be changed to (possibly) 3000 at create-nullstack-app repo

useful references:

server.port = process.env['NULLSTACK_SERVER_PORT'] || process.env['PORT'] || 5000;

console.log('\x1b[31m%s\x1b[0m', ' ' + line.trim());

https://github.com/nullstack/create-nullstack-app/blob/master/src/template/README.md
https://github.com/nullstack/create-nullstack-app/blob/master/src/template/_env

@MarceloBorgesP
Copy link
Contributor

Let me work on that!

@MarceloBorgesP
Copy link
Contributor

@Mortaro check if this is what we need pls!

@Mortaro
Copy link
Member Author

Mortaro commented Jan 7, 2022

merged into #next thanks @MarceloBorgesP!

@Mortaro Mortaro closed this as completed Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants