Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support urls with/without trailing slashes in Nullstatic #30

Closed
GuiDevloper opened this issue Feb 28, 2021 · 1 comment
Closed

Support urls with/without trailing slashes in Nullstatic #30

GuiDevloper opened this issue Feb 28, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@GuiDevloper
Copy link
Member

GuiDevloper commented Feb 28, 2021

Examples:
Accessing nullstack.app/contributors in Github Pages
Should work equal than accessing nullstack.app/contributors/

Targets those issues registered on Github Pages side:
jekyll/jekyll#4440
https://stackoverflow.com/questions/33270605/github-pages-trailing-slashes
https://marcgg.com/blog/2016/03/14/github-pages-jekyll/

@Mortaro Mortaro added the bug Something isn't working label Feb 28, 2021
@Mortaro
Copy link
Member

Mortaro commented Feb 28, 2021

This seems to be an issue with the way Github deals with trailing slashes.

I solved this by generating both versions of the file, for example: contributors.html and contributors/index.html

nullstack/create-nullstatic-app@eee4ea4

This solution should allow the programmer to not even think about structure while not having additional weight for the visitors.

By default Nullstack removes trailing slashes from router.path and rel canonical so this update should work greatly!

@Mortaro Mortaro closed this as completed Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants