Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate configurable.environment #83

Closed
Mortaro opened this issue Jun 8, 2021 · 0 comments
Closed

Deprecate configurable.environment #83

Mortaro opened this issue Jun 8, 2021 · 0 comments
Labels
good first issue Good for newcomers

Comments

@Mortaro
Copy link
Member

Mortaro commented Jun 8, 2021

Nullstack has a redundant feature that allows you to define secrets and settings by environment like:
settings.production.name = "Tinky Winky"

This was useful before Nullstack had proper environment support and could be deprecated now so the user can set secrets like:

secrets.name = environment.production ? "Tinky Winky" : "Dipsy"

Also the user will probably just use .env instead

Hints 1:
https://github.com/nullstack/nullstack/blob/master/server/configurable.js
All this could be deleted and replaced with simple objects. Freezing could become a simple Object.freeze.

Tests:
https://github.com/nullstack/nullstack/blob/master/tests/src/ContextSecrets.test.js

I want to remove unneeded features before i claim 1.0

@Mortaro Mortaro added the good first issue Good for newcomers label Jun 8, 2021
@Mortaro Mortaro closed this as completed Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant