Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install cathook data into a local directory #768

Open
JustTNE opened this issue Jun 22, 2019 · 8 comments
Open

Install cathook data into a local directory #768

JustTNE opened this issue Jun 22, 2019 · 8 comments
Labels
Milestone

Comments

@JustTNE
Copy link
Collaborator

JustTNE commented Jun 22, 2019

Currently, cathook stores it's configs and other files in /opt/cathook. Ideally we should store those files in a directory located in the cathook folder.

@JustTNE JustTNE added this to the Cathook 1.0 milestone Jun 22, 2019
@BenCat07
Copy link
Member

I disagree.

@BenCat07
Copy link
Member

Due to catbots.

@JustTNE
Copy link
Collaborator Author

JustTNE commented Jun 22, 2019

Nothing a symlink can't fix.

@BenCat07
Copy link
Member

So, symlink and change permissions of your cathook folder to be writeable by everyone? What could go wrong

@JustTNE
Copy link
Collaborator Author

JustTNE commented Jun 23, 2019

So, symlink and change permissions of your cathook folder to be writeable by everyone? What could go wrong

What's the difference between this and the current /opt/cathook/data directory?

@GenericException
Copy link
Contributor

I can see why this would make some sense, keeping things consolidated in one spot in all, but I disagree.

  1. Cathook is not designed to be used like portable software, so local storage in relative paths doesn't make sense.
  2. Keeping a consistent location among all users makes accessing this information easier for everyone.
  3. Catbots as Ben references should all be able to easily lookup this data. This kinda is an extension of point 2.
  4. This is the correct usage of the opt folder

@JustTNE
Copy link
Collaborator Author

JustTNE commented Jun 23, 2019

I can see why this would make some sense, keeping things consolidated in one spot in all, but I disagree.

  1. Cathook is not designed to be used like portable software, so local storage in relative paths doesn't make sense.
  2. Keeping a consistent location among all users makes accessing this information easier for everyone.
  3. Catbots as Ben references should all be able to easily lookup this data. This kinda is an extension of point 2.
  4. This is the correct usage of the opt folder
  1. Who says that it isn't? Literally everything other than its data directory is completely portable.
  2. Also makes it easier for vac to literally search for 1 folder. Bash: [ -d /opt/cathook ]
  3. Catbots already do many symlinks. For example we symlink the entire steamapps directory of the user to /opt/steamapps and then symlink those to all catbots.
  4. The opt directory is supposed to contain entire applications, not additional data for an otherwise self contained program.

I'm of the opinion that the portability and vac resistance vastly outweighs the disadvantages of a single symlink.

@GenericException
Copy link
Contributor

GenericException commented Jun 24, 2019

1. Who says that it isn't? Literally everything other than its data directory is completely portable.
2. Also makes it easier for vac to literally search for 1 folder. Bash: [ -d /opt/cathook ]
3. Catbots already do many symlinks. For example we symlink the entire steamapps directory of the user to /opt/steamapps and then symlink those to all catbots.
4. The opt directory is supposed to contain entire applications, not additional data for an otherwise self contained program.
  1. I'm of the opinion that the portability and vac resistance vastly outweighs the disadvantages of a single symlink.
  1. Second thought, you're correct.
  2. Fair, my train of thought is that it makes helping newer users easier since things are consistent. I don't have stats or anything, but I'd say it wouldn't be unreasonable to assume that a fair number of people using cathook are very new to linux.
  3. Fair
  4. 🙃 ok
  5. Fair, but why would anyone cheat on an account that matters to them?

@JustTNE JustTNE added this to Low priority in Issue Triage Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Issue Triage
  
Low priority
Development

No branches or pull requests

4 participants
@BenCat07 @GenericException @JustTNE and others