Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Data race when entering a new query #76

Closed
3 tasks done
nullxception opened this issue Jan 4, 2023 · 1 comment
Closed
3 tasks done

Bug: Data race when entering a new query #76

nullxception opened this issue Jan 4, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@nullxception
Copy link
Owner

nullxception commented Jan 4, 2023

Type

Other

Bug description

Sometimes the timeline would get replaced by pending search that has been replaced by a new search.

Steps to reproduce

  1. Search for something
  2. while loading, search again for something else
  3. If the network is not fast enough (e.g. caused by smaller result on second search), the first search will be displayed on the timeline instead of the second search result.

Android version

13

App version

1.2.7

Screenshots or videos

No response

Solution

Easiest but temporary solution:

  • having a timestamp for checking mechanism before updating timeline state.

Long-term solution:

  • rearchitect timeline state to be more local than using state container like riverpod

Additional context

No response

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@nullxception nullxception added the bug Something isn't working label Jan 4, 2023
@nullxception
Copy link
Owner Author

nullxception commented Feb 19, 2023

Closed as this bug is indirectly fixed on e9610e9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant