Fix Popper Timeout Tracking #1417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add a few missing types * Let the code breathe a bit
jherdman
commented
May 23, 2024
src/Popper/Popper.tsx
Outdated
| const handleKeyDown = (event) => { | ||
| switch (event.keyCode) { | ||
| const handleKeyDown = (event: KeyboardEvent) => { | ||
| switch (event.code) { |
There was a problem hiding this comment.
This change was a result of typing the event. Once this was fixed the types informed me (correctly) that keyCode is deprecated in favour of code.
We noticed that Popper was sometimes closing the dorpdown inaccurately. This was pinned down to timeouts being incorrectly cleared, and thefore sometimes running when they ought not to. Careful examination of the code revealed that they weren't being tracked very well, and thus stomped on or lost. This approach leverages a ref to track the value to avoid loss during re-renders, and to also avoid unnecessary re-renders.
github-actions bot
pushed a commit
that referenced
this pull request
Jun 21, 2024
## [10.2.8](v10.2.7...v10.2.8) (2024-06-21) ### Bug Fixes * Popper Timeout Tracking ([#1417](#1417)) ([e026714](e026714))
|
🎉 This PR is included in version 10.2.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We noticed that Popper was sometimes closing the dorpdown inaccurately.
This was pinned down to timeouts being incorrectly cleared, and thefore
sometimes running when they ought not to. Careful examination of the
code revealed that they weren't being tracked very well, and thus stomped on
or lost.
This approach leverages a ref to track the value to avoid loss during
re-renders, and to also avoid unnecessary re-renders.
Changes include
Feature checklist