New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wezterm active pane not undimming #20
Comments
In navigator, we are only using the wezterm cli to execute commands so It could be a bug within wezterm, I am not sure as I don't use wezterm. |
So I experimented a bit more with it and have found that its only using a keymap that fails. Calling |
Hmmmm... that's really interesting. If the keymap is the culprit then maybe we need to provide some option to keymap, that I am not aware of, or this is a bug in neovim itself 😅. |
Okay I think I found the issue... when calling From reading the Neovim docs: I really don't know enough about terminal escape sequences to say if this is an okay way or not but... one way of fixing it without any noticeable side effects seems to be putting Navigator.nvim/lua/Navigator/mux/wezterm.lua Lines 44 to 51 in a440fea
There is almost certainly some better way to get Wezterm to redraw itself (either from within Neovim or from in the provided Wezterm snippet) but I'm just figuring this stuff out as I go. I mostly just wanted to prove that it is technically possible to fix from within Neovim |
I also tried ':h uv.spawn()' but facing the same issue 😅.
Yes, this seems fairly reasonable. If this works across platforms i.e., windows and unix without any side effects then it would be worth it. @marty-oehme What do you think about the issue and the solution? Did you ever faced this issue while implementing the wezterm integration? |
Actually I don't know how I missed this before, but |
Mh, this is indeed very interesting. @ir-ae I tried your sleep snippet and I have the same behavior: takes 5 secods to highlight the other pane but I can write immediately and when I do it immediately highlights. However, when switching away from nvim the highlight update always happens immediately for me. My best guess for now would be that the issue appears in the wezterm snippet call to pass through the keys to send to the window, thus to neovim which immediately passes it back. Since the issue does happen for you when manually invoking I am unfortunately a bit strapped for time currently, but when I find some I'll take a look to see if we could manually update the wezterm render; or maybe something will develop in your raised issue - thanks for raising it! |
I ran into this using Windows but I've also tested it on my Linux laptop and its the same behaviour
Actually the interesting thing is Okay so literally as I typed that out I realized the difference. The keymaps use And after some quick testing changing the keymap to |
Changing the keymap to use I'm not sure if there is a good solution on the plugin side of things. This really just seems like a Wezterm issue. I'll leave this open for now in case you have a better fix or you want to put a note in the README about the issue but otherwise feel free to close this. |
Thanks for the investigation. Yes, let just leave this issue open for tracking and wait for the explanation from the wezterm team. |
This is now fixed in Wezterm. wez/wezterm#3303 |
Thank you for adding Wezterm support, its something I've wanted in Neovim for a while and it mostly works as expected. The only issue I'm having is when navigating from Neovim back to Wezterm, the inactive styling and cursor style don't change until the next keypress which momentarily makes me think it failed to navigate back to wezterm.
The text was updated successfully, but these errors were encountered: