Update changelog for 0.33.0 #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Looks good, couple of things to resolve then can be merged. I have this locally:
Commits:
* PR #521: Allow instructions to be removed from blocks
* PR #548: Upgrade to LLVM9
* PR #575: Update the release date
* PR #577: llvmlite wheel building fixes
* PR #580: Trove classifiers may be out of date.
* PR #581: Add FAQ entry on LLVM version support.
* PR #582: Adds override for LLVM version check, re-formats docs.
* PR #586: Update changelog for 0.32.1 on master
* PR #590: add python_requires to setup.py
* PR #591: buildscripts: Unpin wheel
* PR #592: Fix meta.yaml
* PR #593: Fix CUDA with LLVM9
Total PRs: 12
CHANGE_LOG
Outdated
Comment on lines
12
to
13
| * PR #586: Update changelog for 0.32.1 on master | ||
| * PR #585: Update changelog for 0.32.1 on release branch |
There was a problem hiding this comment.
Do these need to go in ? I removed similar from the Numba change log.
CHANGE_LOG
Outdated
| * PR #582: Adds override for LLVM version check, re-formats docs. | ||
| * PR #581: Add FAQ entry on LLVM version support. | ||
| * PR #577: llvmlite wheel building fixes | ||
| * PR #576: Update the release date |
CHANGE_LOG
Outdated
| * PR #590: add python_requires to setup.py | ||
| * PR #586: Update changelog for 0.32.1 on master | ||
| * PR #585: Update changelog for 0.32.1 on release branch | ||
| * PR #580: Trove classifiers may be out of date. |
There was a problem hiding this comment.
This should be 2 lines down, after #581
There was a problem hiding this comment.
i guess my script is going by some sort of dates
as per review
stuartarchibald
approved these changes
Jun 3, 2020
CHANGE_LOG
Outdated
| @@ -1,7 +1,30 @@ | |||
| v0.33.0dev | |||
| v0.33.0rc1 | |||
There was a problem hiding this comment.
I think this has the proposed release date in it now and no rc1?
stuartarchibald
approved these changes
Jun 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as titled