Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code library not linked in lowering. Missing inline opportunity. #3398

Open
sklam opened this issue Oct 10, 2018 · 0 comments
Open

Code library not linked in lowering. Missing inline opportunity. #3398

sklam opened this issue Oct 10, 2018 · 0 comments
Labels
caching Issue involving caching performance - run time Performance issue occurring at run time. Task

Comments

@sklam
Copy link
Member

sklam commented Oct 10, 2018

Throughout lowering, there are many invocation that may be uses code in another code-library but are not linking the dependency. This is leading to missed inline opportunity and potentially other issues in caching or AoT.

Example of code that needs updating:

numba/numba/lowering.py

Lines 860 to 865 in 3618091

# Convert argument to match
val = self.context.cast(self.builder, val, typ, signature.args[0])
res = impl(self.builder, [val])
res = self.context.cast(self.builder, res,
signature.return_type, resty)
return res

Should look like:

numba/numba/lowering.py

Lines 834 to 838 in 3618091

res = impl(self.builder, argvals)
libs = getattr(impl, "libs", ())
for lib in libs:
self.library.add_linking_library(lib)

@stuartarchibald stuartarchibald added the caching Issue involving caching label Mar 27, 2019
@stuartarchibald stuartarchibald added performance - run time Performance issue occurring at run time. Task labels Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
caching Issue involving caching performance - run time Performance issue occurring at run time. Task
Projects
None yet
Development

No branches or pull requests

2 participants