Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code duplication in cuda real hw vs simulator #3593

Open
sklam opened this issue Dec 12, 2018 · 0 comments
Open

Remove code duplication in cuda real hw vs simulator #3593

sklam opened this issue Dec 12, 2018 · 0 comments
Labels
CUDA CUDA related issue/PR enhancement

Comments

@sklam
Copy link
Member

sklam commented Dec 12, 2018

There are two devicearray.py files for the cuda backend and there are several methods that are either duplicated or looks very similar. We should consolidate the code to avoid repeating ourselves. The first step may just be moving the duplicated code to a file that the real hw and simulator codepaths can share. In the long term, we should also consider refactoring the interface to reduce the similar looking code.

@stuartarchibald stuartarchibald added the CUDA CUDA related issue/PR label Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CUDA CUDA related issue/PR enhancement
Projects
None yet
Development

No branches or pull requests

2 participants