Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support __mul__ for strings #3834

Closed
stuartarchibald opened this issue Mar 5, 2019 · 3 comments · Fixed by #3952
Closed

support __mul__ for strings #3834

stuartarchibald opened this issue Mar 5, 2019 · 3 comments · Fixed by #3952
Labels
feature_request good first issue A good issue for a first time contributor

Comments

@stuartarchibald
Copy link
Contributor

Feature request

As title. This sort of thing should work:

'abc' * 5
'abc'.__mul__(5)
@stuartarchibald stuartarchibald added good first issue A good issue for a first time contributor feature_request labels Mar 5, 2019
@luk-f-a
Copy link
Contributor

luk-f-a commented Apr 7, 2019

@stuartarchibald, if this is still open I can make a PR.

@stuartarchibald
Copy link
Contributor Author

@luk-f-a this is still open, a PR would be most welcome, thanks for offering!

The use of Numba's extension API is strongly recommended for this task, documentation is here.

If you get stuck/need a hand, the Numba core developers are also available on gitter.im real time chat.

Thanks again.

@luk-f-a luk-f-a mentioned this issue Apr 8, 2019
Merged
@luk-f-a
Copy link
Contributor

luk-f-a commented Apr 8, 2019

@stuartarchibald #3952 is ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature_request good first issue A good issue for a first time contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

__mul__ for strings, initial implementation and tests luk-f-a/numba
2 participants
@stuartarchibald @luk-f-a