Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.49rc1 fail 1 test on windows #5448

Closed
sklam opened this issue Mar 27, 2020 · 5 comments · Fixed by #5459
Closed

0.49rc1 fail 1 test on windows #5448

sklam opened this issue Mar 27, 2020 · 5 comments · Fixed by #5459
Labels
Milestone

Comments

@sklam
Copy link
Member

sklam commented Mar 27, 2020

ERROR: test_wrapper_address_protocol_libm (numba.tests.test_function_type.TestFunctionTypeExtensions)
Call cos and sinf from standard math library.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\Users\ci\32\Miniconda3\envs\testenv_fbf4b59a-0935-4a9d-8efb-05e471655d84\lib\site-packages\numba\tests\test_function_type.py", line 617, in test_wrapper_address_protocol_libm
    mysin = LibM('sinf')
  File "C:\Users\ci\32\Miniconda3\envs\testenv_fbf4b59a-0935-4a9d-8efb-05e471655d84\lib\site-packages\numba\tests\test_function_type.py", line 598, in __init__
    addr = ctypes.cast(self.lib.sinf, ctypes.c_voidp).value
  File "C:\Users\ci\32\Miniconda3\envs\testenv_fbf4b59a-0935-4a9d-8efb-05e471655d84\lib\ctypes\__init__.py", line 361, in __getattr__
    func = self.__getitem__(name)
  File "C:\Users\ci\32\Miniconda3\envs\testenv_fbf4b59a-0935-4a9d-8efb-05e471655d84\lib\ctypes\__init__.py", line 366, in __getitem__
    func = self._FuncPtr((name_or_ordinal, self))
AttributeError: function 'sinf' not found

----------------------------------------------------------------------
@sklam sklam added the bug label Mar 27, 2020
@sklam sklam added this to the Numba 0.49 RC milestone Mar 27, 2020
@sklam
Copy link
Member Author

sklam commented Mar 27, 2020

We'll need to skip/fix this test before 0.49 release

@sklam sklam modified the milestones: Numba 0.49 RC, Numba 0.49.0 Mar 27, 2020
@seibert
Copy link
Contributor

seibert commented Mar 27, 2020

note this is failing on win-32. It looks like win-64 is fine.

@pearu
Copy link
Contributor

pearu commented Mar 29, 2020

winedump -j export msvcrt.dll

shows that sinf is available only in 64-bit DLL. The 32-bit DLL contains only sin.

Suggest skipping the sinf test on 32-bit Windows systems but keep the cos test.

@pearu
Copy link
Contributor

pearu commented Mar 29, 2020

It is possible that on the 32-bit Windows sin is for 32-bit float inputs. If this is the case, then changing conditionally self.lib.sinf to self.lib.sin might work. Also, the cos test requires adjustment as well on the 32-bit Windows platform.

@pearu
Copy link
Contributor

pearu commented Mar 30, 2020

@sklam please see a possible fix in #5459. I cannot verify the fix myself as I don't have immediate access to the 32-bit Windows platform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants