Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide whether or not to support the target kwarg in the numba.jit decorator #5951

Closed
hameerabbasi opened this issue Jul 2, 2020 · 1 comment · Fixed by #5980
Closed
Labels
discussion An issue requiring discussion

Comments

@hameerabbasi
Copy link
Contributor

In a couple of issues, e.g. #5868, users have reported that using the target= kwarg for the numba.jit decorator doesn't always work. While this isn't documented on the website (website docs), it is documented in the docstring, and so anyone running numba.njit? in ipython or Jupyter will find it. An excerpt from the docstring is below:

    target: str
        Specifies the target platform to compile for. Valid targets are cpu,
        gpu, npyufunc, and cuda. Defaults to cpu.

So, there is a decision to be made. Does the Numba team support the kwarg (which means writing tests, fixing up bugs etc.), or not (which means deprecation and removal).

@stuartarchibald stuartarchibald added the discussion An issue requiring discussion label Jul 3, 2020
@stuartarchibald
Copy link
Contributor

Thanks for raising this. I think e.g. 'gpu' is not a target, the rest are valid as there are function registries for these and we should see if they working/if it makes sense for the code path to exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion An issue requiring discussion
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants