Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6102. Problem with non-unique label. #6116

Merged
merged 3 commits into from Aug 11, 2020
Merged

Conversation

sklam
Copy link
Member

@sklam sklam commented Aug 11, 2020

Fixes #6102.

Fixed by updating the _max_label.

Fixed by updating the _max_label.
@sklam sklam added this to the Numba 0.51.0 milestone Aug 11, 2020
Copy link
Contributor

@stuartarchibald stuartarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well found! Could the case from #6102 that triggers this be added please? Thanks.

Copy link
Contributor

@stuartarchibald stuartarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch and fixes. Looks good. RTM on CI pass.

@stuartarchibald stuartarchibald added 4 - Waiting on CI Review etc done, waiting for CI to finish and removed 3 - Ready for Review labels Aug 11, 2020
@sklam sklam mentioned this pull request Aug 11, 2020
42 tasks
@sklam sklam added 5 - Ready to merge Review and testing done, is ready to merge and removed 4 - Waiting on CI Review etc done, waiting for CI to finish labels Aug 11, 2020
@sklam sklam merged commit 8686273 into numba:master Aug 11, 2020
@sklam sklam deleted the fix/iss6102 branch August 11, 2020 21:26
sklam added a commit that referenced this pull request Aug 11, 2020
Fix #6102. Problem with non-unique label.
@mturiansky
Copy link

Thanks for the quick fix! Numba is awesome, and you all are awesome!

@esc
Copy link
Member

esc commented Aug 12, 2020

@mturiansky thanks for the compliments, we appreciate it! 🙏

@stuartarchibald
Copy link
Contributor

Thanks for your support @mturiansky :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to merge Review and testing done, is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parallel function compiles with v0.50.1 and fails with v0.51.0rc1
4 participants