Fix regression on gufunc serialization #6826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+33
to
+40
| dct = dict( | ||
| py_func=gb.py_func, | ||
| signature=gb.signature, | ||
| identity=self._identity, | ||
| cache=gb.cache, | ||
| is_dynamic=self._is_dynamic, | ||
| targetoptions=gb.targetoptions, | ||
| typesigs=gb._sigs, |
There was a problem hiding this comment.
Think self._frozen should be in here, it is transmittable state and should prevent further compilation.
| got = np.zeros_like(arr) | ||
| double(arr, out=expect) | ||
| cloned(arr, out=got) | ||
| self.assertPreciseEqual(expect, got) |
There was a problem hiding this comment.
Wonder if these tests ought to also check, self._frozen, self.gufunc_builder._sigs, self._is_dynamic and self._identity, just to make sure the state is carrying appropriately?
There was a problem hiding this comment.
These attributes are now tested explicitly
stuartarchibald
added
4 - Waiting on author
sklam
added
4 - Waiting on reviewer
| # expected value of attributes | ||
| self.assertTrue(cloned._frozen) | ||
|
|
||
| cloned.disable_compile() |
There was a problem hiding this comment.
I don't think this has any effect but is harmless.
stuartarchibald
approved these changes
Mar 23, 2021
stuartarchibald
added
5 - Ready to merge
esc
pushed a commit
to esc/numba
that referenced
this pull request
Mar 25, 2021
Fix regression on gufunc serialization (cherry picked from commit 056bf6b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6821.