Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression in CUDA: Set stream in mapped and managed array device_setup #6828

Merged
merged 1 commit into from Mar 17, 2021

Conversation

gmarkall
Copy link
Member

Since #6827 is a regression in the CUDA Array Interface in 0.53, I'm suggesting this for 0.53.1 - this problem has been known about for a while (#6233) but only started causing a problem now that the stream is exported on the CUDA Array Interface.

Fixes #6827.
Fixes #6233.

@sklam @esc Could this have a buildfarm run if it's still available this week please?

cc @awthomp.

@gmarkall gmarkall added 3 - Ready for Review CUDA CUDA related issue/PR labels Mar 15, 2021
@gmarkall gmarkall added this to the 0.53.1 milestone Mar 15, 2021
Copy link
Contributor

@stuartarchibald stuartarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, looks good.

@stuartarchibald stuartarchibald added 4 - Waiting on CI Review etc done, waiting for CI to finish Pending BuildFarm For PRs that have been reviewed but pending a push through our buildfarm and removed 3 - Ready for Review labels Mar 17, 2021
@stuartarchibald
Copy link
Contributor

Buildfarm ID: numba_smoketest_cuda_yaml_28.

@stuartarchibald
Copy link
Contributor

Buildfarm ID: numba_smoketest_cuda_yaml_28.

Passed.

@stuartarchibald stuartarchibald added 5 - Ready to merge Review and testing done, is ready to merge BuildFarm Passed For PRs that have been through the buildfarm and passed and removed 4 - Waiting on CI Review etc done, waiting for CI to finish Pending BuildFarm For PRs that have been reviewed but pending a push through our buildfarm labels Mar 17, 2021
@stuartarchibald stuartarchibald merged commit 1d9577c into numba:master Mar 17, 2021
esc pushed a commit to esc/numba that referenced this pull request Mar 25, 2021
Fix regression in CUDA: Set stream in mapped and managed array device_setup

(cherry picked from commit 1d9577c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to merge Review and testing done, is ready to merge BuildFarm Passed For PRs that have been through the buildfarm and passed CUDA CUDA related issue/PR
Projects
None yet
2 participants