Fix issues with locating/parsing source during DebugInfo emission. #7744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works around issues with source that cannot be parsed when looking for a line containing `def` so as to get the correct line info for use in DebugInfo emission. It adds tests for this and also the case where the function source is simply unobtainable. Fixes numba#7730
stuartarchibald
added
Effort - medium
esc
previously requested changes
Jan 26, 2022
esc
added
4 - Waiting on author
esc
dismissed
their stale review
Nevermind. The initial strings are already the same.
esc
added
5 - Ready to merge
Conflicts: numba/tests/test_debuginfo.py
|
776f5df fixes conflicts against mainline. |
stuartarchibald
added
4 - Waiting on reviewer
esc
added
5 - Ready to merge
esc
pushed a commit
to esc/numba
that referenced
this pull request
Jan 27, 2022
Fix issues with locating/parsing source during DebugInfo emission.
esc
pushed a commit
to esc/numba
that referenced
this pull request
Jan 27, 2022
Fix issues with locating/parsing source during DebugInfo emission.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around issues with source that cannot be parsed when
looking for a line containing
defso as to get the correct lineinfo for use in DebugInfo emission. It adds tests for this and
also the case where the function source is simply unobtainable.
Fixes #7730