Fix #7713: Ensure _prng_random_hash return has correct bitwidth #7748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the hash width is 32 bits, get_next_int32 needs to be used because that returns a 32-bit integer, as opposed to get_next_int, which returns a 64-bit integer regardless of the supplied bitwidth. This commit also alters the signature of _prng_random_hash to use _Py_hash_t as the return type - it will be equal to types.intp, but the intent should be clearer.
|
Giving this a full build farm run over the weekend to see if it fixes #7713 on our CI too!
|
esc
added
the
BuildFarm Passed
|
Build farm green for win32 on e6df66d |
|
@esc Thanks for the BF run - I've now marked this as ready for review (Iooks like I forgot to do that after the CI passed on Friday night). |
esc
approved these changes
Jan 17, 2022
esc
added
5 - Ready to merge
esc
pushed a commit
to esc/numba
that referenced
this pull request
Jan 26, 2022
Fix numba#7713: Ensure _prng_random_hash return has correct bitwidth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the hash width is 32 bits,
get_next_int32()needs to be used because that returns a 32-bit integer, as opposed toget_next_int(), which returns a 64-bit integer regardless of the supplied bitwidth.This commit also alters the signature of
_prng_random_hash()to use_Py_hash_tas the return type - it will be equal totypes.intp, but the intent should be clearer.Tested so far on Python 3.10 on 32- and 64-bit Windows with:
This is the list of 16 failing tests reported in #7713 (comment)
Fixes #7713.