Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite numba.{carray,farray} support using @overload #8009

Closed
stuartarchibald opened this issue Apr 27, 2022 · 2 comments
Closed

Rewrite numba.{carray,farray} support using @overload #8009

stuartarchibald opened this issue Apr 27, 2022 · 2 comments
Assignees
@stuartarchibald
Labels
Task

Comments

@stuartarchibald
Copy link
Contributor

#7996 highlights that there's likely an issue with numba.{carray,farray}, where the CallableTemplate uses Numba types instead of Python values for the defaults in the typer kwargs. Getting this to work at all with @overload_glue was extremely challenging, as a result, instead of fixing the issue noted by @sklam here #7996 (comment) the time will be spend on translating numba.carray and numba.farray to use @overload as it is known to help prevent such issues and also translating it will improve compilation performance for these functions (fewer wrappers!).
@stuartarchibald stuartarchibald mentioned this issue Apr 27, 2022
Merged
@stuartarchibald stuartarchibald self-assigned this Apr 27, 2022
@stuartarchibald
Copy link
Contributor Author

To minimise merge conflicts, this should be done once #7999 is merged.

@stuartarchibald
Copy link
Contributor Author

Fixed in #8432, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stuartarchibald stuartarchibald

Labels
Task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stuartarchibald