Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to issue #1. #3

Closed
wants to merge 2 commits into from
Closed

Fix to issue #1. #3

wants to merge 2 commits into from

Conversation

@sangwinc
Copy link
Author

@christianp Do you accept this, and are there any further additions to this project? I'd like to keep STACK in sync with this list!

@christianp
Copy link
Member

Sorry, I completely forgot about this! I'm off work this week for half term, but I'll look at it when I'm back.

christianp added a commit that referenced this pull request Feb 28, 2024
Apparently they're often mistaken for square brackets.

from #3
@christianp
Copy link
Member

@sangwinc now I've looked at #1 again, I see I didn't add these to symbols.json. Instead, I added a file brackets.json, listing bracket characters that aren't normalised by NFKD to the standard parenthesis, curly brace, or square bracket characters. The only ones in this PR that weren't in my list were the light left/right tortoise shell ornaments, so I've added those.

For convenience, I'll repeat what I said in my last comment to #1: you can detect bracket characters by looking for character classes Ps and Po, normalise with NFKD, then apply the mapping from brackets.json if necessary.

@christianp christianp closed this Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants