Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some capture cannot be shown(the capture app should display the asset, whether it have metadata or not.) #1548

Closed
sync-by-unito bot opened this issue Apr 25, 2022 · 11 comments

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Apr 25, 2022

tammy
capture app
issues :Some capture cannot be shown
expectation:All captures can be shown without a problem
steps to reproduce:

  1. Register an account
  2. Create an VIDEO asset using API
  3. Login to Capture App
  4. OK to restore assets
  5. Cannot see the pre-created capture
  6. Take another PHOTO capture
  7. Can see capture created in step Bump rxjs from 6.5.5 to 6.6.0 #6
  8. Logout and try to login again, OK to restore assets
  9. Still see only one capture (created in step Bump rxjs from 6.5.5 to 6.6.0 #6)
  10. Use API to get assets under this user account, can see two assets without a problem

﹍the capture app should display the asset, whether it have metadata or not.﹍

User email: napaviy691@idurse.com

┆Issue is synchronized with this Asana task by Unito
┆Created By: Scott Yan

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Apr 25, 2022

➤ Kenny Hung commented:

after qa testing, the finding

  1. if create an asset without metadata, the captureapp won’t display this asset.
  2. if create an asset with metadata, the captureapp will display this asset.

@sync-by-unito sync-by-unito bot changed the title Some capture cannot be shown Some capture cannot be shown(the capture app should display the asset, whether it have metadata or not.) Apr 26, 2022
@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 16, 2022

➤ Sam commented:

Kenny Hung how a user can create a capture without metadata?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 16, 2022

➤ Kenny Hung commented:

Sam As I know, only use Capture App or Creator Gallery on CC currently, because we haven't let normal users create an asset by API yet. But Tammy Yang hope let capture app can display the asset whether it has metadata or not.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 25, 2022

➤ Kenny Hung commented:

Sam cc Tammy Yang
Just confirm this task will move to 0526 sprint?

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 25, 2022

➤ Sam commented:

Kenny Hung yes.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 25, 2022

➤ Kenny Hung commented:

Thanks. I also adjust the due day to next Tuesday.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented May 26, 2022

➤ Tammy Yang commented:

This is associated with a later goal, move to next sprint

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 9, 2022

➤ Sam commented:

Tammy Yang, as explained here ( https://app.claap.io/numbers-protocol/why-can-t-see-captures-without-metadata-c-O35CsUM4Uy-Fx5ToyrWbkWA ) the way capture-lite works is

  • it fetches all assets from backend.

  • from those assets it generate proof using asset + asset.information (aka metadata)

    • assets without metadata are ignored [code line ( https://github.com/numbersprotocol/capture-lite/blob/c485e6d662cc46490cf92a7d25ff5fe3b15fd1aa/src/app/shared/dia-backend/asset/downloading/dia-backend-downloading.service.ts#L63 )]
  • then generated proofs are shown to users.

Currently we have 2 place to upload assets

  1. capture app (guaranteed to have metadata)
  2. backend API (aka https://dia-backend-dev.numbersprotocol.io/api/v3/assets/ ( https://dia-backend-dev.numbersprotocol.io/api/v3/assets/ ))

However, backend API allows uploading assets without metadata. But as you mentioned before assets without metadata does not make sense for us.

Therefore actual solution might be to change backend API to allow upload assets with metadata only.

Let me know if we should close this ticket or move it backend related task.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 9, 2022

➤ Tammy Yang commented:

Sam this was opened by QA, so if you think the user story is not reasonable, please continue the discussion with Scott Yan and Kenny Hung

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 9, 2022

➤ Sam commented:

Scott Yan, Kenny Hung as explained here ( https://app.claap.io/numbers-protocol/why-can-t-see-captures-without-metadata-c-O35CsUM4Uy-Fx5ToyrWbkWA ) the way capture-lite works is

  • it fetches all assets from the backend.

  • from those assets, it generates proof using asset + asset.information (aka metadata)

    • assets without metadata are ignored [code line ( https://github.com/numbersprotocol/capture-lite/blob/c485e6d662cc46490cf92a7d25ff5fe3b15fd1aa/src/app/shared/dia-backend/asset/downloading/dia-backend-downloading.service.ts#L63 )]
  • then generated proofs are shown to users.

Currently, we have 2 places to upload assets

  1. capture app (guaranteed to have metadata)
  2. backend API (aka https://dia-backend-dev.numbersprotocol.io/api/v3/assets/ ( https://dia-backend-dev.numbersprotocol.io/api/v3/assets/ ))

However, the backend API allows uploading assets without metadata. But as Tammbe mentioned before in the slack huddle assets without metadata do not make sense for us.

Therefore actual solution might be to change the backend API to allow uploading assets with metadata only.

@sync-by-unito sync-by-unito bot closed this as completed Jun 16, 2022
@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jun 16, 2022

➤ Sam commented:

Scott Yan, Kenny Hung, Tammy Yang, I'm closing this ticket and creating a new ( https://app.asana.com/0/1201016280880500/1202457621128495/f ) one for the backend team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants