Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After taking the photos, can confirm or choose to retake #1820

Closed
sync-by-unito bot opened this issue Jul 15, 2022 · 5 comments
Closed

After taking the photos, can confirm or choose to retake #1820

sync-by-unito bot opened this issue Jul 15, 2022 · 5 comments

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Jul 15, 2022

┆Issue is synchronized with this Asana task by Unito
┆Created By: Tammy Yang

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 15, 2022

➤ Sam commented:

Bofu Chen, here is the pull ( #1805 ).

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 15, 2022

➤ Bofu Chen commented:

Sam Current UI is different from the design a bit. Please help update, thanks!

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 15, 2022

➤ Bofu Chen commented:

Tammy Yang This is current UI seen on my Samsung Z Fold2.

3 known issues

  1. The positions of the back and confirm buttons, and the header beight are not ideal on my phone. Considering that the phone resolution is not general, I will accept this PR first.
  2. No black footer behind the camera button.
  3. Unconfirmed temporary photos will not be dropped. Sam will fix this issue with another PR.

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 15, 2022

➤ Bofu Chen commented:

Sam For deleting the unconfirmed temp photos ( https://github.com/numbersprotocol/capture-lite/pull/1805/files#r919876763 ), please open a task for following up on the status and assign me as a collaborator. Thanks

@sync-by-unito
Copy link
Author

sync-by-unito bot commented Jul 15, 2022

➤ Sam commented:

Bofu Chen here is follow-up task ( https://app.asana.com/0/0/1202598061994093/f ).

@sync-by-unito sync-by-unito bot closed this as completed Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants