Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue] ionic can't display the asset upload from dashboard when creator is null #3116

Open
sync-by-unito bot opened this issue Nov 28, 2023 · 7 comments

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Nov 28, 2023

User story

As a user of the Capture service, I want all uploaded assets from Dashboard to be displayed seamlessly, regardless of their origin or upload source. This ensures a consistent and user-friendly experience when accessing and viewing assets.

Reproduce step

  1. Upload asset from dashboard (Turn off claim copyright toggle)
  2. pull down refresh on Capture Cam
  3. can't find the asset just upload from dashboard

If user doesn't claim creator, the asset won't display at the Cam my capture tab.

Expectation

No matter the asset is uploaded from where it should be displayed.

The asset uploaded from Dashboard with "claim copyright toggle off" is expected to be seen in "COLLECTED" tab in CaptureCam

Sample: bafkreifnw4pdzdimmgtwydq4rt6fv4nyv7zkp5cl5mzeyvymfwm6bzdsaq

Additional information:

Related issue:

[issue] Not all assets upload via Dashboard can be seen in Capture Cam

current logic:

VERIFIED TAB display logic tab:

  1. fetch user assets
  2. for each asset show asset if diaBackendAsset.information.proof is not empty AND diaBackendAsset.information.information is not empty

COLLECTED TAB display logic tab:

  1. fetch user assets orderBy: 'source_transaction'
  2. no filter logic is applied just shows response from step 1

┆Issue is synchronized with this Asana task by Unito
┆Created By: Kenny Hung

Copy link
Author

sync-by-unito bot commented Nov 28, 2023

➤ Sherry Chung commented:

Kenny Hung Please help to clarify

Did the user claim he is the creator while uploading by Dashboard.

If the user claim he is the creator

  1. The capture should appear in "Verified" tab in CaptureCam

If the user didn't claim he is the creator

  1. The capture should appear in "COLLECTED" tab in CaptureCam

Let me know above situation fit.

Copy link
Author

sync-by-unito bot commented Nov 28, 2023

➤ Kenny Hung commented:

Sherry Chung (cc Scott Yan)

#1, Yes, it will display, but it shows on the bottom instead of the top. Could refer this task ( https://app.asana.com/0/1201083422707776/1206046186816173/f ).

#2, No, it won't show in the VERIFIED or COLLECTED tab.

Copy link
Author

sync-by-unito bot commented Nov 28, 2023

➤ Kenny Hung commented:

Update the title & description.

Copy link
Author

sync-by-unito bot commented Nov 28, 2023

➤ Sherry Chung commented:

Kenny Hung I update the description, including

  1. add more explanation about what the asset is registered with CaptureDashboard, with which toggle on/off
  2. Update the expectation. Where do user expect to see the assets.

Copy link
Author

sync-by-unito bot commented Nov 28, 2023

➤ Sherry Chung commented:

I'll set the priority to high. QA verified by Sherry, move to Capture Cam sprint backlog.

Copy link
Author

sync-by-unito bot commented Dec 20, 2023

➤ Sherry Chung commented:

For this tasks, we might need to redefined the logic for which assets will show in ‘Verified’ and which will show in Owned

https://dt42-numbers.slack.com/archives/C05UCBW1CE4/p1703073921347869?thread_ts=1703069808.678979&channel=C05UCBW1CE4&message_ts=1703073921.347869 ( https://dt42-numbers.slack.com/archives/C05UCBW1CE4/p1703073921347869?thread_ts=1703069808.678979&channel=C05UCBW1CE4&message_ts=1703073921.347869 )

I’ll update the conclusion later.

Copy link
Author

sync-by-unito bot commented Jan 2, 2024

➤ Sherry Chung commented:

Please follow the latest logic in [FR] Defining what assets should display in "Verified" folder and what should display in "Collected" folder ( https://app.asana.com/0/0/1206212142922269 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants