Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] completeness of uploaded assets #3149

Open
sync-by-unito bot opened this issue Dec 21, 2023 · 2 comments
Open

[Issue] completeness of uploaded assets #3149

sync-by-unito bot opened this issue Dec 21, 2023 · 2 comments

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Dec 21, 2023

Description

While working on [FR] sort assets in VERIFIED tab by uploaded_at I found that few assets uploaded to backend

  • have no proof (asset.information.proof === undefined)
  • have 1 digit timestamp (asset.information.proof.timestamp.toString().length === 1 ) expected to be equal to 10
  • have null timestamp (assets.information.proof.timestamp === null)

Steps to Reproduce

  1. Fetch all assets from target account
  2. for each asset
  3. check asset.information.proof !== undefined (not empty)
  4. check asset.information.proof.timestamp.toString().length

Expected Behavior

  • Expected: none of asset.information.proof should be undefined, empty

  • Expected: none of asset.information.proof.timestamp.toString().length should be 1.

  • Expected: none of asset.information.proof.timestamp should be null

Actual Behavior

  • Actual: Found 7 (in target account)

  • Actual: Found 2 (in target account)

  • Actual: Found 1 (in target account)

Logs

undefinedProof bafybeibj75vij255as2p5nyf2nassyvehyzgyurbefk2hthg5bjkw2jx3y

undefinedProof bafybeifywxumhd53pw6pa4tvbrr27tdx7wurz5agnifgzwvgghpt4yu5ia

undefinedProof bafybeieab5gm6lxpngy2houuzbliz4xacpzntwvsxllpzndes42sghdvom

undefinedProof bafybeiedl7b2eiogvyuleuwf5taldlacildz2i5ypn52cdyoky4s6rwo4a

undefinedProof bafybeidjlqmbph2xxs6admtz7ztv547ri2xfapwqyjljzjegomorikqarm

undefinedProof bafybeidefhy23wdpfzryg5yxb2hgf5zpgc7ugw2576wv5jbh52qhhj3bbq

undefinedProof bafybeigf5n7akxzzdkrdctqks66jxhdkae3w6pli22qcamrqu4z3uyrgxi

timestampLengthIsOne bafybeiaq35rz6mwqjcdw2bgwftxm4nraslyn5vqb7j4r36ddmeeab724im

timestampLengthIsOne bafkreib7lsnqwzarfvmvl6mbrd4no3l3jj6px6onfq5idoze3nhzhhaiia

timestampNull bafybeihy2ktguevmtci6vw65w6p2v3sigaavagi6fogdge5rsexckqpa24

Environment

  • NodeJS script, fetch target account assets and loop through with if conditions

┆Issue is synchronized with this Asana task by Unito
┆Created By: Sam

@sync-by-unito sync-by-unito bot changed the title [Issue] Short description of this issue [Issue] completeness of uploaded assets Dec 21, 2023
Copy link
Author

sync-by-unito bot commented Dec 21, 2023

➤ Sam commented:

Kenny Hung I used your capture cam account as a target account. Therefore in your account I found some incomplete assets and I will look forward to find root cause.

Scott Yan before asking backend team to check if there are any incomplete assets should I try with other account (preferably with lots of assets)

Copy link
Author

sync-by-unito bot commented Dec 21, 2023

➤ James Chien commented:

Sam Backend doesn't validate the data inside information (meta field when uploading), so the behavior is possible if the asset is manually uploaded. I would suggest deleting these assets if it troubles testing.

We could also just assume any asset that have the unexpected data above can be excluded when processing in Capture Cam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants