Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input Validation and Correction is not working properly anymore #48

Closed
GolexPrime opened this issue Sep 8, 2021 · 0 comments · Fixed by #52
Closed

Input Validation and Correction is not working properly anymore #48

GolexPrime opened this issue Sep 8, 2021 · 0 comments · Fixed by #52
Assignees
Labels
bug Something isn't working

Comments

@GolexPrime
Copy link
Contributor

Describe the bug
The input validation of the questionnaire-modal does not work with type string anymore. This also prohibits the proper storage of a given answer. Furthermore the input correction also only works on types decimal and integer if the first entered character is indeed a number (nonetheless, the correct value is persisted).

To Reproduce
Steps to reproduce the behavior:

  1. Load the Generic Reference Questionnaire into the app.
  2. Open the "Fragegruppe 1" category.
  3. Enter someting into the input "Das ist eine Freitextabfrage".
  4. The button on the bottom does not turn green.
  5. Close the modal and open it again.
  6. The given answer will not reappear.
  7. Without closing the modal navigate to the question "Das ist eine Dezimalzahlenabfrage" and enter anything besides a number.
  8. If the entered value starts with anything but a number the input correction is not executed.

Expected behavior

  • The validation for type string should recognize an entered string.
  • An input for elements of type integer and/or decimal should prohibit invalid input.

Screenshots
Screenshot 2021-09-08 at 09 43 03
Screenshot 2021-09-08 at 09 43 47

Smartphone (please complete the following information):

  • Device: iOS Simulator
  • OS: iOS 12

Additional context

  • The input validation issue came up with a change in the file questionnaireModal.jsx
  • The input correction error seems to be the result of a change that occurred in how RN handles the value updates of input elements
@GolexPrime GolexPrime added the bug Something isn't working label Sep 8, 2021
@GolexPrime GolexPrime self-assigned this Sep 8, 2021
@GolexPrime GolexPrime linked a pull request Sep 8, 2021 that will close this issue
@GolexPrime GolexPrime linked a pull request Sep 8, 2021 that will close this issue
@GolexPrime GolexPrime removed a link to a pull request Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant