Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prop-types for components #50

Closed
mbastian93 opened this issue Sep 8, 2021 · 0 comments · Fixed by #112
Closed

Add prop-types for components #50

mbastian93 opened this issue Sep 8, 2021 · 0 comments · Fixed by #112
Assignees
@mbastian93
Labels
clean up remove unused parts or clean up code documentation Improvements or additions to documentation enhancement New feature or request
Milestone
Release v1.0.0

Comments

@mbastian93
Copy link
Contributor

For now, eslint shows quite a few warnings because the prop-types for the components are not defined.
These should be defined with 'prop-types'.
@mbastian93 mbastian93 added documentation Improvements or additions to documentation enhancement New feature or request clean up remove unused parts or clean up code labels Sep 8, 2021
@mbastian93 mbastian93 self-assigned this Sep 8, 2021
@mbastian93 mbastian93 added this to the Release v1.0.0 milestone Feb 17, 2022
@mbastian93 mbastian93 mentioned this issue Apr 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbastian93 mbastian93

Labels
clean up remove unused parts or clean up code documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
Release v1.0.0
Development

Successfully merging a pull request may close this issue.

add propTypes for all components NUMde/compass-numapp-frontend
1 participant
@mbastian93