Skip to content
This repository has been archived by the owner on Sep 1, 2023. It is now read-only.

Remove Python shebang / executable bits #2119

Closed
scottpurdy opened this issue May 12, 2015 · 11 comments · Fixed by #3426
Closed

Remove Python shebang / executable bits #2119

scottpurdy opened this issue May 12, 2015 · 11 comments · Fixed by #3426

Comments

@scottpurdy
Copy link
Contributor

This task is to:

  1. Remove "shebang" lines from files. These are the lines at the start of a file that look like #!/usr/bin/env python.
  2. Remove the executable bit from Python scripts.

Original proposal below.


Currently, our Python convention is that any executable Python scripts should have the following:

  1. An if __name__ == "__main__": block
  2. First line should be #!/usr/bin/env python
  3. File should have executable bit set

This proposal is to remove steps 2 and 3 since they are unnecessary and add extra steps. Plus the "entry_points" option in the setup.py script allows you to specify files or functions that should be installed as executable scripts, bypassing the need for steps 2 and 3.

@rhyolight
Copy link
Member

👍

@oxtopus
Copy link
Contributor

oxtopus commented May 13, 2015

👍 Especially as we consider Windows support

@souravsingh
Copy link
Contributor

Is the issue open?

@rhyolight
Copy link
Member

@souravsingh Yes, do you wish to work on it?

@souravsingh
Copy link
Contributor

Thanks! I would like to work on the issue

@rhyolight
Copy link
Member

@souravsingh Great! Please have a read of our Development Process document, and sign our contributor's license. Let me know and I will assign you.

@souravsingh
Copy link
Contributor

@rhyolight A small question: Why the contributor's license? I am seeing it for the first time in an open-source project.

@souravsingh
Copy link
Contributor

I am also sorry for asking such a bad question

@rhyolight
Copy link
Member

Contributor's license agreements are very common practices among companies who host open source projects. When you sign a CLA, it says that all your code contributions are copyright of the company hosting the open source software, not yourself. This is a common practice among us companies like Yahoo, Facebook, Google, etc. It allows ownership of the codebase to stay with one entity so major decisions about the code can be made more easily in the future.

Sent from my MegaPhone

On Feb 28, 2016, at 4:06 AM, Sourav Singh notifications@github.com wrote:

@rhyolight A small question: Why the contributor's license? I am seeing it for the first time in an open-source project. I am sorry for the bad question.


Reply to this email directly or view it on GitHub.

@souravsingh
Copy link
Contributor

Thanks for the answer. I have signed the Agreement and have reviewed the docs.

@rhyolight
Copy link
Member

Thanks, @souravsingh! We'll process the document tomorrow.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants