-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Remove Python shebang / executable bits #2119
Comments
👍 |
👍 Especially as we consider Windows support |
Is the issue open? |
@souravsingh Yes, do you wish to work on it? |
Thanks! I would like to work on the issue |
@souravsingh Great! Please have a read of our Development Process document, and sign our contributor's license. Let me know and I will assign you. |
@rhyolight A small question: Why the contributor's license? I am seeing it for the first time in an open-source project. |
I am also sorry for asking such a bad question |
Contributor's license agreements are very common practices among companies who host open source projects. When you sign a CLA, it says that all your code contributions are copyright of the company hosting the open source software, not yourself. This is a common practice among us companies like Yahoo, Facebook, Google, etc. It allows ownership of the codebase to stay with one entity so major decisions about the code can be made more easily in the future. Sent from my MegaPhone
|
Thanks for the answer. I have signed the Agreement and have reviewed the docs. |
Thanks, @souravsingh! We'll process the document tomorrow. |
This task is to:
#!/usr/bin/env python
.Original proposal below.
Currently, our Python convention is that any executable Python scripts should have the following:
if __name__ == "__main__":
block#!/usr/bin/env python
This proposal is to remove steps 2 and 3 since they are unnecessary and add extra steps. Plus the "entry_points" option in the
setup.py
script allows you to specify files or functions that should be installed as executable scripts, bypassing the need for steps 2 and 3.The text was updated successfully, but these errors were encountered: