Skip to content
This repository has been archived by the owner on Sep 1, 2023. It is now read-only.

Py and C++ classes use same init params #2616

Closed
1 task
Tracked by #2290
breznak opened this issue Sep 29, 2015 · 3 comments
Closed
1 task
Tracked by #2290

Py and C++ classes use same init params #2616

breznak opened this issue Sep 29, 2015 · 3 comments

Comments

@breznak
Copy link
Member

breznak commented Sep 29, 2015

EDIT: This issue is to enforce that py and C++ use the same init params. Doing otherwise is against the principle that those 2 implementations are identical. This is fixing (unfortunately not, but cornering) a real problem where SDR representations differ in SP in Py/C++ implementations.

@rhyolight
Copy link
Member

Needs discussion from other @numenta/nupic-committers.

@rhyolight
Copy link
Member

This would be a whole lot easier to digest if there were separate issues for the SP and the TM, each with different PRs that change default param values. I don't like them mixed together, because they are completely different algorithms and subjects.

@breznak
Copy link
Member Author

breznak commented Aug 4, 2016

This would be a whole lot easier to digest if there were separate issues for the SP and the TM

agreed. closing this issue then.

@breznak breznak closed this as completed Aug 4, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants