package_data dict passed to setup() in nupic's setup.py may be superfluous

[vitaly-krugl]

The package_data dict passed to setup() in nupic's setup.py may be superfluous. In PR #2617, my code is loading a .json file from "nupic/frameworks/opf/common_models/anomaly_params_random_encoder/". This json file is covered by the rule recursive-include src/nupic *.capnp *.json *.tpl *.txt *.xml in nupic's MANIFEST.in, but not covered by any rule in package_data. Despite this omission from package_data, all tests passed, and I verified that the tar.gz file generatred by a local setup.py sdist build includes that .json file.

[vitaly-krugl]

@oxtopus had this to say about it in #1736:

On the subject of MANIFEST.in and superfluous package_data, according to https://docs.python.org/3.4/distutils/sourcedist.html#specifying-the-files-to-distribute:

If you do supply your own MANIFEST, you must specify everything: the default set of files described above does not apply in this case.

I interpret that to mean that if you use MANIFEST.in (which we do), then it doesn't matter what is in package_data. The files need to be added in MANIFEST.in. In which case, we can remove package_data from setup.py.