Skip to content
This repository has been archived by the owner on Sep 1, 2023. It is now read-only.

C++11 standard transform #177

Merged
merged 32 commits into from Sep 18, 2014
Merged

C++11 standard transform #177

merged 32 commits into from Sep 18, 2014

Conversation

breznak
Copy link
Member

@breznak breznak commented Sep 5, 2014

1/ set -std=c++11 flag
2/ verify in travis env
3/ transform code with clang-modernize
EDIT:
base compilers (for C++11 feature support) are gcc 4.8, clang-3.4 (used in OSX build CI)
tested to run with nupic (python)
TODO:
4/ workaround coveralls gcc 4.6 vs 4.8 issue
5/ fix c++11 problems with stdc++ on OSX

Fixes #178.

@rhyolight rhyolight added this to the Sprint 29 milestone Sep 5, 2014
@rhyolight rhyolight added the build label Sep 5, 2014
@breznak
Copy link
Member Author

breznak commented Sep 5, 2014

It builds on my env. Trying to workaround the travis "no gcc 4.8"-bug as you mentioned on the ML,

@breznak breznak mentioned this pull request Sep 5, 2014
Closed
@breznak
(temporarily) remove NULLpointer region InputTest
c3307fe 
references should never be null, actuall code does not compile under clang 3.6 that enforces that
please review
@rhyolight
Copy link
Member

@scottpurdy

@breznak
clang-modernized
90e7dca 
Conflicts:
	src/main/engine/Input.cpp
	src/test/testeverything/engine/InputTest.cpp
@breznak
Revert "(temporarily) remove NULLpointer region InputTest"
d78607c 
This reverts commit c3307fe.
@breznak breznak added the ready label Sep 5, 2014
@breznak
Copy link
Member Author

breznak commented Sep 5, 2014

@rhyolight the gcc failure seems to be that coveralls use gcc 4.6, not 4.8 which I only exported in travis pre_install hook. Any ideas?
https://travis-ci.org/numenta/nupic.core/jobs/34542221#L856

@breznak
Copy link
Member Author

breznak commented Sep 5, 2014

the OSX issue (missing std::move() in libstdc++ shipped on Mac)
https://travis-ci.org/numenta/nupic.core/jobs/34542223#L228
will need some fixing, but all needed info seems to be here:
https://svn.boost.org/trac/boost/ticket/8092

@breznak
Copy link
Member Author

breznak commented Sep 5, 2014

Otherwise, the automated changes to c++ should be more or less stable and are eagerly waiting for your reviews 😈

@rhyolight rhyolight modified the milestones: Sprint 30, Sprint 29 Sep 5, 2014
@breznak
change stdlib to libc++ from libstdc++ on OSX
7a6fead 
to fix problems with c++11, std::move missing for example
@coveralls
Copy link

Coverage Status

Coverage decreased (-43.22%) when pulling 7a6fead on breznak:c++11 into a3a2216 on numenta:master.

@breznak
Copy link
Member Author

breznak commented Sep 7, 2014

flagging this 'help wanted', I'd need someone with OSX to test the right stdc++ library, and someone who knows about coveralls, thx!

@utensil
Copy link
Member

utensil commented Sep 8, 2014

@breznak said:

the gcc failure seems to be that coveralls use gcc 4.6, not 4.8 which I only exported in travis pre_install hook. Any ideas?
https://travis-ci.org/numenta/nupic.core/jobs/34542221#L856

The reason is that the default gcc tool chain on the machine is gcc(4.6) and gcov(4.6), and gcc-4.8 needs the postfix, so is gcov-4.8. Fortunately, cpp-coveralls provided an option to specify the location of gcov, you just need to find it and pass an option of --gcov THE_LOCATION to it at https://github.com/numenta/nupic.core/blob/master/.travis.yml#L50

@rhyolight
Copy link
Member

That's great, @scottpurdy. Thanks for jumping in.

@coveralls
Copy link

Coverage Status

Coverage increased (+15.52%) when pulling 1ab1bac on breznak:c++11 into 5ec7c01 on numenta:master.

@oxtopus oxtopus mentioned this pull request Sep 18, 2014
Closed
Austin Marshall and others added 2 commits September 18, 2014 12:47
@oxtopus
Copy link
Contributor

oxtopus commented Sep 18, 2014

Please see breznak#1 to get this up to par with OS X

@oxtopus
Copy link
Contributor

oxtopus commented Sep 18, 2014

You're so quick!

@breznak
Copy link
Member Author

breznak commented Sep 18, 2014

I'm ⌚ ing you :-D

@breznak
Copy link
Member Author

breznak commented Sep 18, 2014

And we're 🍏

@oxtopus
Copy link
Contributor

oxtopus commented Sep 18, 2014

👍 Thanks, everyone!

oxtopus added a commit that referenced this pull request Sep 18, 2014
@oxtopus
Merge pull request #177 from breznak/c++11
f80787e 
C++11 standard transform
@oxtopus oxtopus merged commit f80787e into numenta:master Sep 18, 2014
@oxtopus oxtopus mentioned this pull request Sep 18, 2014
Closed
@breznak breznak deleted the c++11 branch September 18, 2014 20:59
@rhyolight
Copy link
Member

👏

oxtopus pushed a commit to oxtopus/nupic.core that referenced this pull request Sep 25, 2014
Revert "Merge pull request numenta#177 from breznak/c++11"
8ab6254 
This reverts commit f80787e, reversing
changes made to 5ec7c01.
@rhyolight rhyolight mentioned this pull request Oct 14, 2014
Closed
7 tasks
@rhyolight rhyolight modified the milestones: Alpha, C++11 Oct 14, 2014
breznak added a commit to breznak/nupic.core that referenced this pull request Oct 18, 2014
@breznak
Revert "Revert "Merge pull request numenta#177 from breznak/c++11""
b09c68a 
This reverts commit 8ab6254.

Conflicts:
	.travis.yml
	src/main/test/Tester.cpp
	src/test/testeverything/TestEverythingMain.cpp
	src/test/unit/test/TesterTest.hpp
@breznak breznak mentioned this pull request Oct 18, 2014
Merged
breznak added a commit to breznak/nupic.core that referenced this pull request Jul 17, 2019
@breznak
Merge pull request numenta#506 from Zbysekz/randomUnitTests
37c5b4a 
Fixing skipped unit tests - random, solving issue numenta#177
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@breznak breznak

Labels
status:help wanted type:build
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.

Switch build to C++11
6 participants
@breznak @rhyolight @coveralls @utensil @scottpurdy @oxtopus