"nta" replaced by "nupic" (namespace and folder)

[david-ragazzi]

Solves numenta/nupic-legacy#811 (2nd and 4th item)

[david-ragazzi]

@rhyolight @oxtopus @scottpurdy

Could you help me to find why only OSX tests are failing?

https://travis-ci.org/numenta/nupic.core/builds/42146187

This PR only rename the namespace from nta to nupic. Is there some external library used by OSX and specified on Travis which references nta?

The error:

Undefined symbols for architecture x86_64:
  "nta::count_gt(float*, float*, float)::localThreshold", referenced from:
  nupic::count_gt(float*, float*, float) in CondProbTableTest.cpp.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[3]: *** [unit_tests] Error 1
make[2]: *** [CMakeFiles/unit_tests.dir/all] Error 2
make[1]: *** [CMakeFiles/tests_unit.dir/rule] Error 2
make: *** [tests_unit] Error 2

[oxtopus]

A change like this seems ok to me. Would like others to weigh in, though.

You will need to rename the src/nta to src/nupic in order to make it work, however.

[david-ragazzi]

You will need to rename the src/nta to src/nupic in order to make it work, however.

Shit.. I forgot this.. Thank you!

[david-ragazzi]

@oxtopus Same error with OSX...

[rhyolight]

@oxtopus Same error with OSX...

Doesn't look like the same error to me: https://travis-ci.org/numenta/nupic.core/builds/42229029. All builds are in an error state.

[david-ragazzi]

Doesn't look like the same error to me: https://travis-ci.org/numenta/nupic.core/builds/42229029. All builds are in an error state.

@rhyolight Please, check this: https://travis-ci.org/numenta/nupic.core/builds/42146187

[rhyolight]

@david-ragazzi I tried building locally and got the same error:

Linking CXX executable unit_tests
Undefined symbols for architecture x86_64:
  "nta::count_gt(float*, float*, float)::localThreshold", referenced from:
      nupic::count_gt(float*, float*, float) in CondProbTableTest.cpp.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [unit_tests] Error 1
make[1]: *** [CMakeFiles/unit_tests.dir/all] Error 2
make: *** [all] Error 2

[rhyolight]

@david-ragazzi See https://github.com/numenta/nupic.core/pull/243/files#diff-5fc4121d5c281de47186c9f30e425bdbR3893:

       "movq  __ZZN3nta8count_gtEPfS0_fE14localThreshold@GOTPCREL(%%rip), %%r11\n\t"

There's an nta buried in that string. I don't understand what is going on here, but this is probably the culprit.

[david-ragazzi]

There's an nta buried in that string. I don't understand what is going on here, but this is probably the culprit.

Holy crap, Batman! This was the problem! Thanks @rhyolight !

[david-ragazzi]

humm.. not enough... I mean this is really the problem but simply rename from nta to nupic is not enough. Someone with linkage and ASM expertise could help me?

[oxtopus]

See david-ragazzi#2

I was able to get the mangled name by commenting out the lines between the ifdef, and then using otool to get the symbol:

otool -SV libnupic_core.a  | grep localTh

[rhyolight]

That sound awful. If you need someone to talk to, I'm here.

Sent from my MegaPhone

On Nov 30, 2014, at 5:02 PM, Austin Marshall notifications@github.com wrote:

See DavidRagazzi#2

I was able to get the mangled name by commenting out the lines between the ifdef, and then using otool to get the symbol:

otool -SV libnupic_core.a | grep localTh
—
Reply to this email directly or view it on GitHub.

[david-ragazzi]

Thanks @rhyolight and @oxtopus! Now it is green!

Please, don't merge yet, we need point numenta/nupic-legacy#1568 to this PR and ensure that it gets green too..

[rhyolight]

@david-ragazzi numenta/nupic-legacy#1568 is passing, so 👍. You ready for a merge?

[david-ragazzi]

Yes, of course!!