Remove dependency on NUPIC_CORE_RELEASE environment variable #552
Conversation
|
Actually hold off. I just realized that this doesn't include the egg anymore and that I need to figure out a way to include that |
|
@oxtopus @scottpurdy: I added the egg as well |
| pip wheel --wheel-dir=dist/wheels . | ||
| echo "pip wheel -r requirements.txt" | ||
| pip wheel --wheel-dir=dist/wheels -r requirements.txt | ||
| echo "python setup.py bdist_wheel" |
There was a problem hiding this comment.
Better to set -o xtrace rather than include echos in the shell scripts.
| # Build all NuPIC and all required python packages into dist/wheels as .whl | ||
| # files. | ||
| echo "pip wheel --wheel-dir=dist/wheels ." | ||
| pip wheel --wheel-dir=dist/wheels . | ||
| pip wheel --wheel-dir=dist/wheels -r requirements.txt |
There was a problem hiding this comment.
won't this choke on nupic.bindings in requirements.txt?
There was a problem hiding this comment.
This is in nupic.core. nupic.bindings isn't in requirements.txt because these are the requirements for nupic.bindings
|
@oxtopus - please merge when you're happy with this |
|
Let's wait on this. I want to test it a bit more |
|
@oxtopus: I think this is ready. Please let me know what you think |
|
This doesn't actually remove the dependency? An exception is still raised if the var is missing. Am I missing something? |
|
The exception is raised if the --nupic-core-dir is not passed in. Setup.py is not longer dependent on the user setting the environment variable NUPIC_CORE_RELEASE, but rather its on an input flag, which matches the format of nupic's setup.py. I think this is just so the user doesn't have to run the additional command to set the environment variable and because this is a more standard format. |
|
@akhilaananthram - If we do a PyPI release of nupic.bindings, will it be able to find the included cmake stuff without needing this flag? |
|
Not for source builds. You would need to provide the flag. The binaries should be fine though. |
|
@scottpurdy What is the status of this? LGTM. |
Remove dependency on NUPIC_CORE_RELEASE environment variable
Now the user must use the flag --nupic-core-dir when calling setup.py. This should allow us to eliminate the setup.py that is at the top level as well since that was just there to run "pip wheel ." and we no longer run that.
Fixes #551
@oxtopus @scottpurdy