-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Configuration base class must use pkg_resources to find config file(s) #1593
Comments
@rhyolight - are you planning on doing this now or would it be helpful for me to send a PR for it? |
PR welcome! Sent from my MegaPhone
|
@scottpurdy I started working on it, but got neck-deep in distutils and setuptools docs. The only line of code I wrote was |
Hey @scottpurdy, do you want to pair on this? It would be helpful to me, cause I have to work on this right away for a release and I need to learn this stuff anyway. How about I create a remote branch with some initial changes and comment on it with questions when I have something you can look at. Then you can lambaste me for doing it wrong. ;) |
I think I found the right place to start: http://peak.telecommunity.com/DevCenter/setuptools#including-data-files |
Yeah Matt, just let me know how I can help. I actually wasn't familiar with the process for making sure the files are included with setup.py but that link looks good. The only thing odd in that link is that they are using |
Gotcha, thanks. Will ping you later when I have some code pushed. |
Currently, this class searches several places for configuration files, but does not take advantage of
pkg_resources
to get them. In order to properly distribute nupic as a python package, it must be updated to usepkg_resources
to find these files.The existing path logic can stay in place, and users should still be able to override with
NTA_CONF_PATH
. But when these methods find nothing,pkg_resources
should be used to attempt to access them.cc @scottpurdy
The text was updated successfully, but these errors were encountered: