Optimize imports #1134
Optimize imports #1134
Conversation
|
This obviously needs some work. The automated "Optimize Imports" refactoring I applied from PyCharm was a bit too aggressive. I'll manually work on this when I have time. But there are a lot of unused and poorly stated imports throughout the code that could benefit from this refactoring. |
|
ooh... PyCharm.. 😍 |
|
@scottpurdy / @chetan51 Please review. The optimize imports refactoring was applied with tooling, and I had to go back into some of the source files and undo some of them that should not have been touched. For the most part, the refactoring removes unused imports and reorders existing imports for (1) system libs (2) third party libs & (3) local imports in that order. |
|
@david-ragazzi I've just started using PyCharm as well, and I really like it so far! |
|
|
||
| from nupic.frameworks.opf.opfutils import ( | ||
| validateOpfJsonValue) | ||
| from nupic.frameworks.opf.opftaskdriver import ( | ||
| IterationPhaseSpecLearnOnly, | ||
| IterationPhaseSpecInferOnly, | ||
| IterationPhaseSpecInferOnly, |
There was a problem hiding this comment.
Fix this and other formatting errors
|
Looks good, other than new formatting problems caused by the automatic refactor. |
Yeah, JetBrains' products are amazing! |
| @@ -26,4 +26,4 @@ | |||
| """ | |||
|
|
|||
| from nupic.bindings.math import NearestNeighbor | |||
| from nupic.bindings.algorithms import svm_01, svm_dense | |||
| from nupic.bindings.algorithms import svm_01, svm_dense | |||
|
@scottpurdy See #1148 |
Fixes #1133.