Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xfce4-notifyd shows only themes that have css file #677

Closed
sjb0x49 opened this issue Jun 27, 2017 · 4 comments
Closed

xfce4-notifyd shows only themes that have css file #677

sjb0x49 opened this issue Jun 27, 2017 · 4 comments

Comments

@sjb0x49
Copy link

sjb0x49 commented Jun 27, 2017

Xfce4-notifyd no longer checks for gtkrc files for themes, it now accepts only gtk.css. The change was committed a while ago:
https://git.xfce.org/apps/xfce4-notifyd/commit/?id=a75d021670d31388623c30e6e8f63da70d6c82af
Not a huge deal, but it would be nice for notifications to match the theme.
Thank you all so much for your work, I love the numix themes.

@khurshid-alam
Copy link
Contributor

The link is giving me "Page not found".

And as of now, we do not have proper support Xfce4-notifyd (gtk3). But it is on my radar.

@sjb0x49
Copy link
Author

sjb0x49 commented Jul 6, 2017

https://git.xfce.org/apps/xfce4-notifyd/commit/?id=a75d021670d31388623c30e6e8f63da70d6c82af
Sorry about that, the editor changed the url for the link, for some reason. (you can see while hovering the first link) I probably did something wrong. Anyway this should show the commit. Thank you

@ragazenta
Copy link
Contributor

After looking commit histories and old pull requests, I notice that xfce-notify-4.0/gtk.css had already been added (#512) but then removed (30b14f7), it was moved into scss.

Should it be restored? But I also notice some styles are different: background-color, border-color, etc.

Xfce4-notifyd (gtk3) use xfce-notify-4.0/gtk.css to override styles on main gtk.css theme and it will appear in Configuration, CMIIW. I think the Default option in Configuration has already matched the theme.

@khurshid-alam
Copy link
Contributor

Feel free to open a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants