Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obviate leptosfmt wrapper #118

Open
2 tasks
srid opened this issue Aug 27, 2023 · 0 comments
Open
2 tasks

Obviate leptosfmt wrapper #118

srid opened this issue Aug 27, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@srid
Copy link
Contributor

srid commented Aug 27, 2023

https://github.com/bram209/leptosfmt/releases/tag/0.1.13 is released with the two necessary changes that will allow us to finally get rid of this wrapper.

command = pkgs.writeShellApplication {
name = "leptosfmt-forall";
runtimeInputs = [
cfg.package
modify-unless-unchanged
];
text = ''
# leptosfmt doesn't take multiple arguments yet
# https://github.com/bram209/leptosfmt/issues/63
for file in "$@"; do
# Use the modify-unless-unchanged hack until this is implemented:
# https://github.com/bram209/leptosfmt/issues/64
modify-unless-unchanged leptosfmt "$file"
done
'';
};

  • Upstream 0.1.13 to nixpkgs
  • Use that in this module (should we still keep the wrapper for older versions, or require user to use newer nixpkgs?)
@srid srid added the enhancement New feature or request label Aug 27, 2023
@srid srid changed the title Simplify leptosfmt wrapper Obviate leptosfmt wrapper Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant