Make default TestAgency URI unique per run (v2) #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Charlie! I've resolved conflicts and set this to auto-merge when CI passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement for #931. Fixes #764
This change allows an engine to be created within a running NUnit Test, on .NET FX. Unfortunately I had to cut my losses on supporting the same in .NET Core after several hours of reflection woes - have broken that out into #946.
This is a useful feature for acceptance style testing of runners - we have various examples in our own console tests where we've had to interact with non-public engine classes to test, which we ideally want not to be necessary.
The first commit adds a failing test, which is fixed in the second commit. The third commit removes a couple of workarounds we've previously built in to get around this problem.