NUnit2045 code-fix does not correctly lift asynchronous assertions into Assert.Multiple

[yaakov-h]

I have NUnit2045 (Call independent assert statements from inside an Assert.Multiple) triggering on the following code:

Assert.That(response.StatusCode, Is.EqualTo(HttpStatusCode.OK));
Assert.That(response.Content.Headers.ContentType?.MediaType, Is.EqualTo("application/json"));
Assert.That(response.Content.Headers.ContentType?.CharSet, Is.EqualTo("utf-8"));
Assert.That(await response.Content.ReadAsStringAsync(), Is.EqualTo(responseBody));

If I apply the code-fix, I am left with the following invalid code:

Assert.Multiple(() =>
{
	Assert.That(response.StatusCode, Is.EqualTo(HttpStatusCode.OK));
	Assert.That(response.Content.Headers.ContentType?.MediaType, Is.EqualTo("application/json"));
	Assert.That(response.Content.Headers.ContentType?.CharSet, Is.EqualTo("utf-8"));
	Assert.That(await response.Content.ReadAsStringAsync(), Is.EqualTo(responseBody));
});

This code binds to Assert.Multiple(TestDelegate) which causes the following error:

CS4034: The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

I would expect that we should use the Assert.Multiple(AsyncTestDelegate) overload by adding async to the lambda, like so:

Assert.Multiple(async () =>
{
	Assert.That(response.StatusCode, Is.EqualTo(HttpStatusCode.OK));
	Assert.That(response.Content.Headers.ContentType?.MediaType, Is.EqualTo("application/json"));
	Assert.That(response.Content.Headers.ContentType?.CharSet, Is.EqualTo("utf-8"));
	Assert.That(await response.Content.ReadAsStringAsync(), Is.EqualTo(responseBody));
});

[manfred-brands]

@yaakov-h Your conclusion seems to be correct. I'll check if I can detect the await being used.