Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Markdown for CHANGES #722

Merged
merged 1 commit into from Apr 9, 2024

Conversation

Bartleby2718
Copy link
Contributor

  • Noticed that this repository uses CHANGES.txt even though its content is compatible with Markdown.
  • Since the repository is hosted on GitHub, I added a @ before each username.

Copy link
Member

@manfred-brands manfred-brands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that.

When you rename a file, you need to make sure any references to it are also updated, e.g.:
https://github.com/nunit/nunit.analyzers/blob/master/src/nunit.analyzers/nunit.analyzers.nuspec#L22

<releaseNotes>See the release notes on https://github.com/nunit/nunit.analyzers/blob/master/CHANGES.txt.</releaseNotes>

@Bartleby2718
Copy link
Contributor Author

@manfred-brands That was already done in the initial commit :)

Copy link
Member

@manfred-brands manfred-brands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed it was. Sorry that I missed it.

Copy link
Member

@mikkelbu mikkelbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @Bartleby2718. The change looks great. I'll merge it now

@mikkelbu mikkelbu merged commit cbe1e2b into nunit:master Apr 9, 2024
6 checks passed
@mikkelbu mikkelbu added this to the Release 4.2 milestone Apr 9, 2024
@Bartleby2718 Bartleby2718 deleted the use-markdown-for-changes branch April 9, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants