Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copyright current year #102

Closed
Arhell opened this issue Dec 11, 2021 · 4 comments · Fixed by #105
Closed

Copyright current year #102

Arhell opened this issue Dec 11, 2021 · 4 comments · Fixed by #105

Comments

@Arhell
Copy link
Member

Arhell commented Dec 11, 2021

Do I need to update the year?
I can do it with js. сс @SeanKilleen

@SeanKilleen
Copy link
Member

@rprouse -- checking in on this to make sure I've got it right.

These changes are for the NUnit site but as of now my area has been constrained to the docs.

If you'd like me to review and assist with these PRs on the site, I'm happy to. Just wanted to make sure you'd like me to proceed in that capacity first. 👍

@rprouse
Copy link
Member

rprouse commented Dec 12, 2021

@SeanKilleen feel free to review, I trust your judgement.

@Arhell updating with JS sounds like a good idea

@SeanKilleen
Copy link
Member

@Arhell I'm thinking since the site is published with Jekyll, if possible we could use liquid formatting which would then update whenever the site is published. Saves the JS code and uses the tooling that the site has adopted.

Let me know your thoughts!

@CharliePoole
Copy link
Contributor

"Do I need to update the year?" I assume you mean the copyright year for the web site in the footer? If yes, I think you do!

Since it only would need to be done once a year and is a trivial change, I'd say do what's easiest.

@Arhell Arhell linked a pull request Dec 13, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants