Prevent crash on invalid --result parsing in NUnitLite #2312
Conversation
| Assert.That(options.ErrorMessages, Has.Exactly(1).Contains("invalid output spec").IgnoreCase); | ||
| } | ||
|
|
||
| #endregion |
There was a problem hiding this comment.
The coding standards is currently empty regarding regions (see e.g. https://github.com/nunit/docs/wiki/Coding-Standards#use-of-regions) - and personally I don't like them :) - but I think that region pairs should be indented to the same level.
|
|
||
| #region Explore Option | ||
| #region Explore Option |
There was a problem hiding this comment.
The coding standards is currently empty regarding regions (see e.g. https://github.com/nunit/docs/wiki/Coding-Standards#use-of-regions) - and personally I don't like them :) - but I think that region pairs should be indented to the same level.
|
Thanks @mikkelbu 🙂 I fixed the #region alignment to be consistent in the file at least. Will merge once CI has passed again. |
|
I prefer indented regions too, but unfortunately adding various Looks good... |
|
Failed AppVeyor build is the unrelated .NET 3.5 failure that we already have an issue for, so I am merging. Very odd that it is only 3.5 failing since we have so few |
This prevents a crash in the NUnitLite runner when an invalid
--resultcommand is specified. It essentially ports nunit/nunit-console#257 to the NUnitLite runner.The major difference is that NUnitLite would previously read the transform specifier, but made no use of it. In line with our vision of not having NUnitLite and the Console have exact matching functionality, I stripped the parsing logic for this out, so it a user specifies a transform, it will be seen as invalid.