New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit test problem on MINGW64 #681
Comments
Please share the text of the 1st error message with us. |
@szepeviktor this one? |
😲 Just a lonely null?? Try with
|
yup, same.
This is for test 47
|
Please debug the output of sprintf here maybe with |
Yes. The complete return value of sprintf, the whole command line. |
I got this
|
Does it run? |
I think we don't support MINGW64, only pure Windows. |
This is highly abnormal in my eyes. See #682! |
I tried pull the PR 682, and still not solves my issue.
|
Could you actually run the dumped value thus command? |
Using Latest PR from #682
Result after I run above code Then I modify it to be like this
and try run it and got this I saw this issue, and try follow remove the php command as said they said here. Then I got the output like this |
@szepeviktor I update execLarastan function to be like this
Then I run PHPUnit, only got 7 failures. Before this 47 failures. |
Thank you for your digging! BTW Do you know how to detect MINGW64? Maybe by PHP_OS and PHP_OS_FAMILY ? |
🤔 https://github.com/laravel/framework/blob/8.x/src/Illuminate/Support/helpers.php#L361 |
This rabbit hole is very deep https://www.php.net/manual/en/function.escapeshellarg.php#123718 You should not get funky stuff like Surprisingly this works in cmd.exe: |
Yup can confirm that
Then I got same 7 failures as before. I still need to remove With PHP at front @szepeviktor is it possible that my PHP environment problem? maybe need someone to test on their windows OS whether they have same issue like me or not. |
From where do you have PHP MINGW64? Have you compiled PHP yourself? |
I uses MINGW64 because I set Git Bash as default terminal in my vscode. I did not compile PHP by myself, I just download it and put it inside Laragon. |
|
If I run with PHP infront If without PHP, I got the 7 failures. I think there is improvements than before where I run got 47 failures. Edit: I tested both in cmd.exe and MINGW64 |
Thank you! |
Yup I already pull your latest changes. @szepeviktor so I run using this command However, I still got 7 failures. |
All right! 🎉 Please open a separate issue if you are curious about those model property tests. I am! |
@szepeviktor Wow. You are legend! 😍 TQVM. I will open seperate issue for the model property tests. Should I wait for the PR merged first? |
No, just open that issue. |
Laravel version: master
Description
I just fork this repo and run composer test on master branch. I got a fail test for my PHPUnit. I already run composer install. Is there anything that I'm doing wrongly?
I'm using windows 10. PHP 7.4.5
The text was updated successfully, but these errors were encountered: