Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Query::whereBetween typehint #1123

Merged
merged 1 commit into from
Feb 21, 2022
Merged

fix: Query::whereBetween typehint #1123

merged 1 commit into from
Feb 21, 2022

Conversation

gitetsu
Copy link
Contributor

@gitetsu gitetsu commented Feb 10, 2022

  • Added or updated tests
  • Documented user facing changes
  • Updated CHANGELOG.md

Changes

Query::whereBetween can accept \Illuminate\Database\Query\Expression.

ref. https://github.com/laravel/framework/blob/171f65d2bf43fb82b7a4fe2ec769f94e962d912c/src/Illuminate/Database/Query/Builder.php#L1126
Breaking changes

@szepeviktor
Copy link
Collaborator

@canvural Do we still need stubs for Builder?

@canvural canvural changed the title fix: Query::whereBetween typehint fix: Query::whereBetween typehint Feb 21, 2022
@canvural canvural merged commit a3282d6 into larastan:master Feb 21, 2022
@canvural
Copy link
Collaborator

Thank you!

@gitetsu gitetsu deleted the patch-1 branch February 22, 2022 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gitetsu @szepeviktor @canvural