Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Larastan to run in CI #113

Merged
merged 2 commits into from
Aug 27, 2018
Merged

Allow Larastan to run in CI #113

merged 2 commits into from
Aug 27, 2018

Conversation

alnutile
Copy link
Contributor

@alnutile alnutile commented Aug 6, 2018

This allows us to run the tool during out CI process.

Maybe there is a reason you disable this for AP_ENV=testing?

Thanks!

This allows us to run the tool during out CI process
@alnutile
Copy link
Contributor Author

alnutile commented Aug 6, 2018

um so you even built tests around it
hmm so I assume you had a good reason to remove it from APP_ENV=testing but just curious why? I can look around issues etc I am sure you answered this before

@szepeviktor
Copy link
Collaborator

There are no commands defined in the "code" namespace.

This message stroke me for an hour in GitLab CI.

@szepeviktor
Copy link
Collaborator

@alnutile Could you adjust the Tests\LarastanServiceProviderTest::testCommandNotAddedInTests test also?

@alnutile
Copy link
Contributor Author

fixing now

@nunomaduro nunomaduro merged commit 49db6f5 into larastan:master Aug 27, 2018
@nunomaduro
Copy link
Collaborator

Thanks @alnutile @szepeviktor !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants