Respect the exit code from phpstan and exit with the same. #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If I recall correctly the return value of |
|
You are absolutely right, TIL. Changed! Thanks for the tip @keryja |
|
I have no idea why travis has failed, some 404 error when trying to install Laravel, but I have the feeling it isn't related to this code ¯_(ツ)_/¯ |
|
Great, welcome back to the ☁️ @nunomaduro! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, larastan always exits with
0regardless of the errors phpstan finds. This change exits the process with the same exit code as phpstan did, allowing a better integration of larastan on build services.