Windows Compatibility #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
also closes #110 |
|
I do confirm that this is working on Ubuntu. Can someone check on Mac OSX? @hordijk This works for you right? |
|
@nunomaduro Yeap, it works on macOS.
|
|
And you have tested that on non bash windows right ?
…On Mon 27 Aug 2018 at 21:31, Sergey Chursin ***@***.***> wrote:
@nunomaduro <https://github.com/nunomaduro> year, it works on macOS.
[image: image]
<https://user-images.githubusercontent.com/980845/44681284-d99b4900-aa48-11e8-9067-dcfa8eed4d7d.png>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#128 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFNFVMYTrBPZYEvWhzVfaftsWGM7ig2yks5uVEj2gaJpZM4WE5R6>
.
|
|
@nunomaduro Yes, right. |
|
Thanks! |
|
The fix in OptionsResolver.php is the same as #110. I can confirm it works fine for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest release doesn't work correctly on Windows. So...
closes #56 and not breaks #55